Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code quality feedback for A0147980U #111

Open
K1ang opened this issue Apr 1, 2017 · 0 comments
Open

Code quality feedback for A0147980U #111

K1ang opened this issue Apr 1, 2017 · 0 comments

Comments

@K1ang
Copy link

K1ang commented Apr 1, 2017

  • Try to have a more meaningful name
    image
  • Missing header comments for classes
    image
  • Try to improve SLAP
    image
  • ModelManager.java seems quite long. Watch out for Single responsibility principle. See if you can split up to smaller classes.
  • Take note of repetitive code blocks.
    image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant