Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code quality feedback for A0140887W #109

Open
K1ang opened this issue Apr 1, 2017 · 0 comments
Open

Code quality feedback for A0140887W #109

K1ang opened this issue Apr 1, 2017 · 0 comments

Comments

@K1ang
Copy link

K1ang commented Apr 1, 2017

  • SLAP is generally ok.
  • Missing header comments for classes and non-trivial methods
    image
    image
  • ModelManager.java seems quite long. Watch out for Single responsibility principle. See if you can split up to smaller classes.
  • Try to use more meaning names for variables.
    image
  • Try to avoid repetitive code blocks.
    image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@K1ang