Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in primary key data types for POST to /exports #52

Open
chambbj opened this issue Mar 4, 2021 · 0 comments
Open

Inconsistency in primary key data types for POST to /exports #52

chambbj opened this issue Mar 4, 2021 · 0 comments

Comments

@chambbj
Copy link
Member

chambbj commented Mar 4, 2021

GRiD-API/swagger.v3.yaml

Lines 344 to 354 in 46b84ec

- name: aoi
in: formData
description: The primary key of the AOI used to export from.
required: true
type: integer
- name: products
in: formData
description: |
A comma-separated list of product primary keys to include in the export.
required: true
type: string

The products parameter must be passed as a string to facilitate comma-separated specification of multiple product exports. On the other hand, the aoi parameter is an integer. Feels awkward and perhaps error prone to sometimes expect integer, other times strings. An alternative could be to pass an array of product pks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant