Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong time scaling in ObserverTimeEvolution #510

Open
JanNiklasB opened this issue Dec 10, 2024 · 1 comment
Open

Wrong time scaling in ObserverTimeEvolution #510

JanNiklasB opened this issue Dec 10, 2024 · 1 comment

Comments

@JanNiklasB
Copy link

Dear All,

the non logarithmic time scaling of the ObserverTimeEvoultion module in the function ObserverTimeEvolution::addTimeRange
in the current master of CRPropa adds the time like min + index * (max - min) / numb.
However, since the maximum index is numb-1, the function only adds times in the range of
(min, min + (numb-1) * (max - min) / numb).

The expected behavior would be a range of time like (min, max),
this can be achieved by calculating the maximum time like min + index * (max - min) / (numb - 1)

@lukasmerten
Copy link
Member

lukasmerten commented Dec 17, 2024

Hi @JanNiklasB
If you have time to provide a fix, I will be happy to check and merge the PR. Otherwise, thanks for reporting the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants