Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Button has no semantics that actually make it a "Link" #48

Open
ccsCoder opened this issue Sep 8, 2023 · 3 comments
Open

Link Button has no semantics that actually make it a "Link" #48

ccsCoder opened this issue Sep 8, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@ccsCoder
Copy link

ccsCoder commented Sep 8, 2023

Describe the bug
Button kind = link has zero semantics. In fact it is rendered with <div class="styles__TypographyWrapper-sc-1n7hass-0 cICjag font sans-serif" font-size="11" font-weight="500" color="#0d0d0d">Link</div>, which does not describe itself as a true "Link".

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Button Demo'
  2. Inspect Link and try checking its accessibility properties.
  3. Note that it is rendered using a div and not as an Anchor.

Expected behavior
I would expect Links to render with Anchor tags with a proper Href etc.

Screenshots
DOMSHOT

<div class="styles__TypographyWrapper-sc-1n7hass-0 cICjag font sans-serif" font-size="11" font-weight="500" color="#0d0d0d">Link</div>

Desktop (please complete the following information):

  • OS: MacOS
  • Browser: Chrome/ Safari
@ccsCoder ccsCoder added the bug Something isn't working label Sep 8, 2023
@Kota-Karthik
Copy link

Kota-Karthik commented Oct 11, 2023

@bigint @ccsCoder @harish-sethuraman
I am interested in doing this issue
So kindly assign me this
Thank you :)

@bigint
Copy link

bigint commented Oct 11, 2023

cc @harish-sethuraman

@Kiranravi10X
Copy link

Button Render Like this Right?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants