Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release #1879

Closed
wants to merge 2 commits into from
Closed

chore: release #1879

wants to merge 2 commits into from

Conversation

hugrbot
Copy link
Collaborator

@hugrbot hugrbot commented Jan 20, 2025

🤖 New release

  • hugr: 0.14.3
  • hugr-core: 0.14.3
  • hugr-model: 0.17.1
  • hugr-llvm: 0.14.3
  • hugr-passes: 0.14.3
  • hugr-cli: 0.14.3
Changelog

hugr

0.14.3 - 2025-02-05

Bug Fixes

Documentation

New Features

hugr-core

0.14.3 - 2025-02-05

Bug Fixes

Documentation

New Features

hugr-model

0.17.1 - 2025-02-05

Bug Fixes

New Features

hugr-llvm

0.14.2 - 2025-01-20

New Features

Refactor

Testing

hugr-passes

0.14.3 - 2025-02-05

Bug Fixes

Documentation

hugr-cli

0.14.1 - 2024-12-18

New Features


This PR was generated with release-plz.

@hugrbot hugrbot added the release Release PR label Jan 20, 2025
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.78%. Comparing base (4054d80) to head (38ef180).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1879   +/-   ##
=======================================
  Coverage   83.77%   83.78%           
=======================================
  Files         196      196           
  Lines       37380    37380           
  Branches    34193    34193           
=======================================
+ Hits        31316    31317    +1     
+ Misses       4287     4286    -1     
  Partials     1777     1777           
Flag Coverage Δ
python 92.34% <ø> (ø)
rust 82.98% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hugrbot hugrbot changed the title chore: release v0.14.3 chore: release v0.15.0 Jan 20, 2025
@hugrbot hugrbot force-pushed the release-plz-2025-01-20T12-34-10Z branch 5 times, most recently from 64c97c1 to 077c402 Compare January 21, 2025 09:22
@hugrbot hugrbot changed the title chore: release v0.15.0 chore: release Jan 21, 2025
@hugrbot hugrbot force-pushed the release-plz-2025-01-20T12-34-10Z branch 5 times, most recently from 5e04412 to d3ce682 Compare January 28, 2025 08:51
@hugrbot hugrbot force-pushed the release-plz-2025-01-20T12-34-10Z branch 2 times, most recently from 542a710 to af087e8 Compare February 4, 2025 18:15
@doug-q doug-q marked this pull request as ready for review February 5, 2025 10:25
@doug-q doug-q requested review from aborgna-q, cqc-alec, ss2165 and a team as code owners February 5, 2025 10:25
@doug-q
Copy link
Collaborator

doug-q commented Feb 5, 2025

It's not clear why hugr is getting a minor version bump?

@hugrbot hugrbot force-pushed the release-plz-2025-01-20T12-34-10Z branch from af087e8 to f2008bc Compare February 5, 2025 10:33
@hugrbot
Copy link
Collaborator Author

hugrbot commented Feb 5, 2025

This PR contains breaking changes to the public Rust API.
Please deprecate the old API instead (if possible), or mark the PR with a ! to indicate a breaking change.

cargo-semver-checks summary

@cqc-alec cqc-alec self-requested a review February 5, 2025 10:43
@aborgna-q
Copy link
Collaborator

It's not clear why hugr is getting a minor version bump?

Not sure why it's not being reported by release-plz, but semver-checks detected this:

    Checking hugr-core v0.14.2 -> v0.14.2 (no change)
     Checked [   0.084s] 94 checks: 93 pass, 1 fail, 0 warn, 0 skip

--- failure enum_variant_added: enum variant added on exhaustive enum ---

Description:
A publicly-visible enum without #[non_exhaustive] has a new variant.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.36.0/src/lints/enum_variant_added.ron

Failed in:
  variant ImportError:ExtensionType in /Users/aborgna/src/hugr/hugr-core/src/import.rs:60

     Summary semver requires new major version: 1 major and 0 minor checks failed

...it comes from #1888

I'll override the bump, and do a minor instead. hugr::import::ImportError is part of the model_unstable feature, so we allow breaks there.

Copy link
Collaborator

@aborgna-q aborgna-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make it a minor bump instead. See previous comment

@aborgna-q aborgna-q requested a review from doug-q February 5, 2025 10:48
@cqc-alec
Copy link
Collaborator

cqc-alec commented Feb 5, 2025

Looks like hugr-llvm had a breaking change too: 8cbbc35 ?

@doug-q
Copy link
Collaborator

doug-q commented Feb 5, 2025

Looks like hugr-llvm had a breaking change too: 8cbbc35 ?

That's already been released. But we didn't get a minor version bump, we should do one now I guess.

@aborgna-q
Copy link
Collaborator

Yeah, release-plz doesn't update the changelog if there are no new commits to a package, and the PR description bugs a bit on those cases (showing the previous release changelog instead).

@aborgna-q
Copy link
Collaborator

The semver-checks issue with LLVM is getting fixed (#1909 / #1908), and it doesn't influence this release.

Should we :shipit: ?

@hugrbot hugrbot closed this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Release PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants