Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Properly report errors for unsupported subscript assignments #738

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mark-koch
Copy link
Collaborator

Fixes #736

@mark-koch mark-koch requested a review from tatiana-s December 20, 2024 09:24
@mark-koch mark-koch requested a review from a team as a code owner December 20, 2024 09:24
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.82%. Comparing base (db86f98) to head (23a2f2e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #738   +/-   ##
=======================================
  Coverage   92.81%   92.82%           
=======================================
  Files          71       71           
  Lines        8159     8162    +3     
=======================================
+ Hits         7573     7576    +3     
  Misses        586      586           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tatiana-s tatiana-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

guppylang.error.InternalGuppyError: Unexpected assignment pattern
3 participants