Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to use underscores in IDs? #2

Open
xuhdev opened this issue Oct 7, 2020 · 3 comments
Open

Possible to use underscores in IDs? #2

xuhdev opened this issue Oct 7, 2020 · 3 comments

Comments

@xuhdev
Copy link
Collaborator

xuhdev commented Oct 7, 2020

Currently IDs use dashes instead of underscores:

id: noaa-weather-data–jfk-airport

Using underscores potentially eases Python users' life by allowing them to type IDs as variable names (say `dax.datasets.noaa_weather_data_jfk_airport). If it's not possible, we would have to do a dash-underscore conversion on one end.

@ptitzler
Copy link
Contributor

ptitzler commented Oct 7, 2020

We'll check with the OpenAIHub team to see if this would pose a problem. My understanding is that we used this convention to mimic what was implicitly done in https://github.ibm.com/IBMCode/Code-Data, where the id is the slug name.

@ckadner
Copy link
Member

ckadner commented Sep 28, 2021

Related issue: machine-learning-exchange/mlx#209

@ckadner
Copy link
Member

ckadner commented Sep 28, 2021

For MLX we need to ensure that given an id that contains underscores (_), the generated DLF/DataShim YAML has a metadata.name that conforms to DNS-1123 subdomain naming restrictions (must consist of lower case alphanumeric characters, - or .)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants