Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate the dbsearch plugin upon starting NodeBB #31

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

HSamiul
Copy link
Contributor

@HSamiul HSamiul commented Feb 14, 2023

Linked Issues: Resolves #4, #5.

Changes: Modified the ./nodebb start command to activate the dbsearch plugin when ran.

Testing: Ran ./nodebb setup, ./nodebb build, and ./nodebb start on a clean install of nodebb. The app running in a browser has a functional search bar.

@HSamiul HSamiul self-assigned this Feb 14, 2023
@HSamiul HSamiul requested a review from egwetzel February 14, 2023 14:34
@HSamiul HSamiul added this to the Sprint 1 milestone Feb 14, 2023
@HSamiul HSamiul linked an issue Feb 14, 2023 that may be closed by this pull request
@HSamiul HSamiul added the enhancement New feature or request label Feb 14, 2023
@egwetzel
Copy link
Contributor

Congrats! Looks wonderful :) Approved.

@egwetzel egwetzel merged commit 417c992 into main Feb 14, 2023
@coveralls
Copy link

coveralls commented Feb 14, 2023

Pull Request Test Coverage Report for Build 4174835333

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 84.979%

Files with Coverage Reduction New Missed Lines %
src/user/approval.js 3 87.39%
Totals Coverage Status
Change from base Build 4157543787: 0.003%
Covered Lines: 22597
Relevant Lines: 25350

💛 - Coveralls

@HSamiul HSamiul deleted the add_search_feature branch February 14, 2023 19:56
@HSamiul HSamiul restored the add_search_feature branch March 22, 2023 00:09
@coveralls
Copy link

coveralls commented Nov 13, 2024

Pull Request Test Coverage Report for Build 4174835333

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 84.979%

Files with Coverage Reduction New Missed Lines %
src/user/approval.js 3 87.39%
Totals Coverage Status
Change from base Build 4157543787: 0.003%
Covered Lines: 22597
Relevant Lines: 25350

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants