Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aria-*] attributes do not have valid values in http://localhost/#/documents/documents/ #16

Open
MaElisa opened this issue Sep 3, 2021 · 1 comment · May be fixed by #129
Open

[aria-*] attributes do not have valid values in http://localhost/#/documents/documents/ #16

MaElisa opened this issue Sep 3, 2021 · 1 comment · May be fixed by #129
Assignees
@MaElisa
Labels
accessibility
Milestone
HW1

Comments

@MaElisa
Copy link
Collaborator

MaElisa commented Sep 3, 2021 •
edited
Loading

image
image

The All documents page has an accessibility score of 84, and the invalid values lead to incorrect interpretations for assistive technologies such as screen readers.
@MaElisa MaElisa closed this as completed Sep 3, 2021
@MaElisa MaElisa reopened this Sep 3, 2021
@MaElisa MaElisa added this to the HW1 milestone Sep 3, 2021
@MaElisa MaElisa self-assigned this Sep 4, 2021
@MaElisa MaElisa linked a pull request Sep 9, 2021 that will close this issue
Open
@MaElisa
Copy link
Collaborator Author

MaElisa commented Sep 9, 2021 •
edited
Loading

To improve the accessibility score from 84 to 91, I removed the invalid aria-control value. Rather than changing it to another value, I removed it because this line with non-ajax is referenced in different locations of the page-- not always will the control be the same across these pages.

@osbahzad osbahzad mentioned this issue Aug 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaElisa MaElisa

Labels
accessibility
Projects
None yet
Milestone
HW1
1 participant
@MaElisa