Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed the front end of the anonymous feature #37

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Completed the front end of the anonymous feature #37

merged 1 commit into from
Sep 26, 2024

Conversation

hibaabdullahhamad
Copy link

I have added an anonymous toggle to the post draft. I edited the file node_modules/nodebb-plugin-composer-default/static/lib/composer.js in order to implement this.

This will allow progression into the next phase of implementing the anonymous feature which involves the back-end, see issue #35.

This PR resolves issue #9.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11040267430

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 82.626%

Files with Coverage Reduction New Missed Lines %
src/meta/errors.js 1 76.74%
src/user/approval.js 3 87.61%
Totals Coverage Status
Change from base Build 11038472453: -0.02%
Covered Lines: 22329
Relevant Lines: 25596

💛 - Coveralls

Copy link

@rkensouh rkensouh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Ready to move on to issue #35.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Marking a post as anonymous
3 participants