Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abdallah feature #7

Closed
wants to merge 10,000 commits into from
Closed

Abdallah feature #7

wants to merge 10,000 commits into from

Conversation

aalman3
Copy link

@aalman3 aalman3 commented Sep 17, 2024

temporary

nodebb-misty and others added 30 commits April 13, 2024 09:18
filter:sockets.sendNewNotificationToUid - fires before emitting "event:new_notification"

filter:sockets.sendNewPostToUid - fires before emitting "event:new_post"

filter:sockets.sendNewTopicToUid - fires before emitting "event:new_topic"

filter:user.toggleFollow- fires before follow/unfollow
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…2518)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
if merge was started from inside the topic
rohanpadhye and others added 28 commits August 18, 2024 15:59
* Refactoring srt/api/posts.js , changes from P1

Implementing the changes I made from project 1

* Update posts.js

Remove double quoted line with console.log

* Update posts.js

Fixed some syntax errors,
Block is not padded by blank lines now
@aalman3 aalman3 closed this Sep 17, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10905775056

Details

  • 41 of 52 (78.85%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.06%) to 82.626%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/meta/configs.js 19 23 82.61%
src/topics/posts.js 15 22 68.18%
Files with Coverage Reduction New Missed Lines %
src/meta/configs.js 1 84.26%
src/meta/errors.js 1 76.74%
src/groups/join.js 1 92.05%
Totals Coverage Status
Change from base Build 10701387427: -0.06%
Covered Lines: 22328
Relevant Lines: 25595

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.