Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVF-1 #209

Closed
Tracked by #210
rya-sge opened this issue Jul 28, 2023 · 1 comment
Closed
Tracked by #210

CVF-1 #209

rya-sge opened this issue Jul 28, 2023 · 1 comment
Assignees
Labels
Next release The issue has been merged into dev and will be part of the next release Security

Comments

@rya-sge
Copy link
Collaborator

rya-sge commented Jul 28, 2023

The check of the pause and frozen state was moved inside to fix the following CVF from the audit report, see #153

Here true is returned even if transfers are paused or the origin address is frozen.
Consider returning false in such a case

Nevertheless, this change creates
a) A cross-dependencies between modules (ValidationModule, PauseModule and EnforcementModule) which "break" the architecture
b) Make a requirement the ValidationModule (and so the RuleEngine) which was originally an optional module

Solution:
It makes sense to perform the different check inside the contract CMTAT_BASE since it is like a controller.

@rya-sge rya-sge changed the title CVF CVF-1 Jul 28, 2023
@rya-sge
Copy link
Collaborator Author

rya-sge commented Sep 4, 2023

Finally the PR #222 moves only the ValidationModule inside a new directory called "Controllers" to avoid confusion.
it makes sense to perform all transfer control inside an only module.

@rya-sge rya-sge mentioned this issue Sep 4, 2023
10 tasks
@rya-sge rya-sge self-assigned this Sep 11, 2023
@rya-sge rya-sge added the Next release The issue has been merged into dev and will be part of the next release label Sep 11, 2023
@rya-sge rya-sge closed this as completed Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Next release The issue has been merged into dev and will be part of the next release Security
Projects
None yet
Development

No branches or pull requests

1 participant