You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The check of the pause and frozen state was moved inside to fix the following CVF from the audit report, see #153
Here true is returned even if transfers are paused or the origin address is frozen.
Consider returning false in such a case
Nevertheless, this change creates
a) A cross-dependencies between modules (ValidationModule, PauseModule and EnforcementModule) which "break" the architecture
b) Make a requirement the ValidationModule (and so the RuleEngine) which was originally an optional module
Solution:
It makes sense to perform the different check inside the contract CMTAT_BASE since it is like a controller.
The text was updated successfully, but these errors were encountered:
Finally the PR #222 moves only the ValidationModule inside a new directory called "Controllers" to avoid confusion.
it makes sense to perform all transfer control inside an only module.
The check of the pause and frozen state was moved inside to fix the following CVF from the audit report, see #153
Nevertheless, this change creates
a) A cross-dependencies between modules (ValidationModule, PauseModule and EnforcementModule) which "break" the architecture
b) Make a requirement the ValidationModule (and so the RuleEngine) which was originally an optional module
Solution:
It makes sense to perform the different check inside the contract CMTAT_BASE since it is like a controller.
The text was updated successfully, but these errors were encountered: