-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PSST] New test -- check local clock for skew #93
Comments
@bbockelm @stlammel |
I worry that Alternate ideas:
|
I added check for clock skew. Local clock is compared with server clock (in this case https://google.com), which is taken from HTTP header. It has precision of ~ 1 sec. I guess it should be enough as only extreme skew can cause some problems. Currently threshold is set to 5 sec. |
What could be the maximum acceptable clock skew? |
A lot of implementations allow for a small number of minutes of clock skew - it's pretty inconsistent. I would maybe set to critical at 5 minutes and warn at 10s? |
Worker nodes with extreme skew can cause GSI failures that are difficult to debug. We should add this as a new PSST test.
Brian notes there is a timestamp in the TLS v1.2 handshake and this can be used as a lightweight mechanism to determine clock skews. Need to lookup an example link.
The text was updated successfully, but these errors were encountered: