Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"required" validation not working. #104

Open
diegovogel opened this issue Feb 20, 2020 · 4 comments
Open

"required" validation not working. #104

diegovogel opened this issue Feb 20, 2020 · 4 comments

Comments

@diegovogel
Copy link

I tried to use the snippet for validation of required fields, but it doesn't seem to be working. I'm not getting any errors (front end or console). It just doesn't seem to be doing anything. I noticed that the last commit was 5 years ago. Has the snippet been tested with Gutenberg?

@tw2113
Copy link
Contributor

tw2113 commented Feb 20, 2020

Very likely not, for the gutenberg testing.

We actually just had this same thing come up over at https://wordpress.org/support/topic/required-field-28/ in case that's not you as well. Basically the snippet as-is fails when it tries to select by #post because Gutenberg doesn't have that DOM element.

@diegovogel
Copy link
Author

Ok thanks for the tip. I noticed that about the #post selector as well. I'll see if I can get it to work. Do you guys have any plans to update the snippet to work with Gutenberg? Or perhaps provide some other way of validating required fields?

@tw2113
Copy link
Contributor

tw2113 commented Feb 20, 2020

Mostly a case of finding the time to update/test/etc. We more than willingly accept pull requests as well to account for the two different editor experiences, in case you find a good working solution on your own and want to pass it along.

@diegovogel
Copy link
Author

Sounds good, if I find a solution I'll share.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants