Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete Implementation of Units in get_data()'s #68

Open
n-beckage opened this issue May 16, 2024 · 0 comments
Open

Complete Implementation of Units in get_data()'s #68

n-beckage opened this issue May 16, 2024 · 0 comments
Assignees
Labels
3 medium priority Medium priority issues enhancement New feature or request

Comments

@n-beckage
Copy link
Collaborator

Set the name attributes in the final nested series return by get_data()'s to contain the units for the respective variable. This is already done for aorc_ob.py and lcd_ob.py but needs to be implemented in the rest of the data acquisition modules. Use utils.add_units() to achieve this. Said function requires var_dict, a dictionary of user_var_names : units. Units should be directly inferred from raw dataset where possible as opposed to being manually set.

@n-beckage n-beckage added enhancement New feature or request 3 medium priority Medium priority issues labels May 16, 2024
@n-beckage n-beckage self-assigned this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 medium priority Medium priority issues enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant