You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have several spots in prep_AEM3D_IAM where we are checking for low flow / negative values and addressing them. Should we be doing this just once? Actually, we should probably be doing the minimal amount of data modification before each step, but at least be consistent with our methods:
AEM3D_prep_IAM.py: 246-8: Removing negative values. I prefer this method of using the nearest points to fill in the points we are taking out as it uses real data instead of just hardcoding a value. But here, we should do this negative removal for ALL three flow datasets just to be safe. A for flow in [flowdf mlflow jsflow] structure would be appropriate.
waterquality.py: 252,256,271: Removing low flows. Pull these three statements out to above that if() statement in 247 and use a similar structure as AEM3D_prep_IAM.py: 246-8.
waterquality.py: 278: Setting the phosdf for low flow days to 0. We should do this in waterquality.py: 252,256,271. The low flow value should be set by looking at those quadratic QC equations and seeing where they start to turn upward. That's the minimum flow values we should pick for waterquality.py: 252,256,271.
Finally, in all these files, we should purge flowdf as a single series name. It's good to use it as the flowdf where we then select a column i.e. flowdf['flow'], but we use is by itself too and we should remove those.
The text was updated successfully, but these errors were encountered:
We have several spots in prep_AEM3D_IAM where we are checking for low flow / negative values and addressing them. Should we be doing this just once? Actually, we should probably be doing the minimal amount of data modification before each step, but at least be consistent with our methods:
AEM3D_prep_IAM.py: 246-8: Removing negative values. I prefer this method of using the nearest points to fill in the points we are taking out as it uses real data instead of just hardcoding a value. But here, we should do this negative removal for ALL three flow datasets just to be safe. A
for flow in [flowdf mlflow jsflow]
structure would be appropriate.waterquality.py: 252,256,271: Removing low flows. Pull these three statements out to above that if() statement in 247 and use a similar structure as AEM3D_prep_IAM.py: 246-8.
waterquality.py: 278: Setting the phosdf for low flow days to 0. We should do this in waterquality.py: 252,256,271. The low flow value should be set by looking at those quadratic QC equations and seeing where they start to turn upward. That's the minimum flow values we should pick for waterquality.py: 252,256,271.
Finally, in all these files, we should purge flowdf as a single series name. It's good to use it as the flowdf where we then select a column i.e. flowdf['flow'], but we use is by itself too and we should remove those.
The text was updated successfully, but these errors were encountered: