Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit testing and test coverage #43

Open
Luke-Pratley opened this issue Apr 22, 2021 · 4 comments
Open

Unit testing and test coverage #43

Luke-Pratley opened this issue Apr 22, 2021 · 4 comments

Comments

@Luke-Pratley
Copy link

Are there any plans for unit tests in RM tools to check sections of code working as expected?

This would help find bugs when someone changes sections of code or introduces anything new.

@Cameron-Van-Eck
Copy link
Collaborator

At the moment, I don't have any plans for any more tests beyond what it already present. I can appreciate the value of having more tests, but at the moment the weight of cost vs value isn't really in favour of further test development, at least for me.

@AlecThomson
Copy link
Contributor

I guess this now partially addressed by #48 ?

@Cameron-Van-Eck
Copy link
Collaborator

I'm not sure. My impression (and Luke can correct me if I'm wrong), is that we were thinking about smaller/more focused tests. The current tests just check the high-level programs (rmsynth1d, rmclean1d, etc), but not the functions inside.

Also, I just realized that the new test framework from #48 isn't running the tests I already wrote (tests/QA_tests.py), so I'll need to figure out how to integrate those together at some point...

@AlecThomson
Copy link
Contributor

I've just put in #53, which now installs all the dependancies (including multinest) runs all the testing in tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants