-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add gensql.gpm.sppl-compatible setting #110
Open
ships
wants to merge
2
commits into
main
Choose a base branch
from
ships/chore/add-sppl-container
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
139d380
to
9e5f11d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
=======================================
Coverage 75.89% 75.89%
=======================================
Files 30 30
Lines 1535 1535
Branches 64 64
=======================================
Hits 1165 1165
Misses 306 306
Partials 64 64 ☔ View full report in Codecov by Sentry. |
bcc92b9
to
f208db1
Compare
1d28a42
to
4236854
Compare
KingMob
reviewed
May 10, 2024
4236854
to
2e96852
Compare
ab6852d
to
55d0d74
Compare
KingMob
approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
These derivations appear to work. This is "ready to merge", though some Nix refactoring could improve the code. That is not top priority before I head out for the week so merges, requests for changes, or changes by rest of team are all welcome.
Reviewing
See updates to readme. The new options are:
one code change
There is a minor Clojure code change and removal of the
dynaload
dependency which is flagged by non-code-coverage in CI. I am not worried but am curious if there is a meaningful way to validate this change's safety besides a happy-path test.