-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests don't pass in released 1.1.1 #469
Comments
Can you try setting the python hashseed first ( Since python 3.3, the hashing used in e.g dictionary keys is non-determininistic and are 'salted' with a unpredictable random values: https://docs.python.org/3.4/reference/datamodel.html#object.__hash__. I understand this is prevent DOS attacks. |
Yes that does allow the tests to pass. This could be done when calling umi-tools from the tests. Since python 3.6, dicts remember their insertion order, and Set's still have no defined order though. All the failing tests are actually in dedup & group ('whitelist_scrb' in the output non-withstanding), The actual issue is in network.breadth_first_search which changes order depending on the actual hash values. |
Closing due to inactivity. There's a (long) outstanding PR for making UMI-tools determininstic (#550) following this issue. One day I might even get that merged... |
Download the umi-tools 1.1.1 release, unzip, install in fresh venv,
add pyyaml and nose, run tests.
14-16 of 58 tests fail. (it varies a bit - RNG related?).
full log:
umitools_fail.txt.
What's up with that?
The text was updated successfully, but these errors were encountered: