Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

something wrong with create_weighted_straight_skeleton_2.h #8686

Closed
RaTiaw opened this issue Jan 10, 2025 · 2 comments · Fixed by #8688 or #8690
Closed

something wrong with create_weighted_straight_skeleton_2.h #8686

RaTiaw opened this issue Jan 10, 2025 · 2 comments · Fixed by #8688 or #8690

Comments

@RaTiaw
Copy link

RaTiaw commented Jan 10, 2025

Issue Details

file: create_weighted_straight_skeleton_2.h
line: 81
it seems like "typename Weights" in the template should be removed

Source Code

            skeleton = CGAL::create_interior_weighted_straight_skeleton_2(
                outer_contour.begin(),
                outer_contour.end(),
                holes.begin(),
                holes.end(),
                outerWeights.begin(),
                outerWeights.end(),
                holeWeights.begin(),
                holeWeights.end(),
            );

C2672: No matching overloaded function found.

Environment

  • Operating system (Windows/Mac/Linux, 32/64 bits): Windows
  • Compiler: MSVC 14.3
  • Release or debug mode: debug
  • Specific flags used (if any):
  • CGAL version: 6.0.8
  • Boost version:
  • Other libraries versions if used (Eigen, TBB, etc.):
@MOHAMMEDANSILKA

This comment has been minimized.

sloriot added a commit that referenced this issue Feb 5, 2025
## Summary of Changes

Fix a number of doc / API issues in 2D straight skeletons, and add more
tests.

TODO:
- [x] More API tests in weighted skeletons
- [x] 6.0.1 version to deal with boost::shared_ptr -> std::shared_ptr

## Release Management

* Affected package(s): `Straight_skeleton_2`
* Issue(s) solved (if any): fix #8686
* Feature/Small Feature (if any): -
* License and copyright ownership: no change
@sloriot sloriot closed this as completed Feb 5, 2025
@MaelRL
Copy link
Member

MaelRL commented Feb 5, 2025

Thank you for the bug report @RaTiaw; it was fixed in #8690.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants