Warnings deprecated declaration regarding triangulate_and_refine_hole

[stla]

Hello,

CRAN has upgraded gcc to version 13.2 and it finds "significant warnings", which are not acceptable by CRAN. The two lines MODULE.h:1074 and MODULE.h:1083 are both a call to PMP::triangulate_and_refine_[and_fair_]hole

Found the following significant warnings:
  MODULE.h:1074: warning: ‘std::tuple<bool, FaceOutputIterator, VertexOutputIterator> CGAL::Polygon_mesh_processing::triangulate_refine_and_fair_hole(PolygonMesh&, typename boost::graph_traits<Graph>::halfedge_descriptor, FaceOutputIterator, VertexOutputIterator, const CGAL::Named_function_parameters<NP_T2, NP_Tag2, NP_Base2>&) [with PolygonMesh = CGAL::Surface_mesh<CGAL::Point_3<CGAL::Epeck> >; FaceOutputIterator = std::back_insert_iterator<std::vector<CGAL::SM_Face_index> >; VertexOutputIterator = std::back_insert_iterator<std::vector<CGAL::SM_Vertex_index> >; NP_T = bool; NP_Tag = CGAL::internal_np::all_default_t; NP_Base = CGAL::internal_np::No_property; typename boost::graph_traits<Graph>::halfedge_descriptor = CGAL::SM_Halfedge_index]’ is deprecated [-Wdeprecated-declarations]
  MODULE.h:1083: warning: ‘std::pair<_Tp1, _Tp2> CGAL::Polygon_mesh_processing::triangulate_and_refine_hole(PolygonMesh&, typename boost::graph_traits<Graph>::halfedge_descriptor, FaceOutputIterator, VertexOutputIterator, const CGAL::Named_function_parameters<NP_T2, NP_Tag2, NP_Base2>&) [with PolygonMesh = CGAL::Surface_mesh<CGAL::Point_3<CGAL::Epeck> >; FaceOutputIterator = std::back_insert_iterator<std::vector<CGAL::SM_Face_index> >; VertexOutputIterator = std::back_insert_iterator<std::vector<CGAL::SM_Vertex_index> >; NP_T = bool; NP_Tag = CGAL::internal_np::all_default_t; NP_Base = CGAL::internal_np::No_property; typename boost::graph_traits<Graph>::halfedge_descriptor = CGAL::SM_Halfedge_index]’ is deprecated [-Wdeprecated-declarations]

Any idea how I can fix that? I don't understand this report. What are the deprecated declarations?

    if(fairhole) {
      const bool success = std::get<0>(
        PMP::triangulate_refine_and_fair_hole(
          mesh, h, 
          std::back_inserter(patch_faces), std::back_inserter(patch_vertices)
        )
      );
      if(!success) {
        Message("Fairing failed.");
      }
    } else {
      PMP::triangulate_and_refine_hole(
        mesh, h, 
        std::back_inserter(patch_faces), std::back_inserter(patch_vertices)
      );
    }

[stla]

No idea?

For me a declaration is something like double x = .... But here what is the problematic declaration?

[sloriot]

From https://github.com/CGAL/cgal/blob/master/Installation/CHANGES.md

Deprecated the overloads of functions CGAL::Polygon_mesh_processing::triangulate_hole(), CGAL::Polygon_mesh_processing::triangulate_and_refine_hole(), and CGAL::Polygon_mesh_processing::triangulate_refine_and_fair_hole() which have output iterators for vertices and faces as parameter. They are replaced by overloads with two additional named parameters.

In your code you can use:

PMP::triangulate_and_refine_hole(
  mesh, h, 
  CGAL::parameters::face_output_iterator(std::back_inserter(patch_faces)).
                    vertex_output_iterator(std::back_inserter(patch_vertices))  
);

[stla]

Thanks! Gonna try immediately.