Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d3q27_pf_velocity - read and write stencil fields in same stage #437

Open
TravisMitchell opened this issue Jul 26, 2023 · 1 comment
Open

Comments

@TravisMitchell
Copy link
Member

There are currently a couple issues with the d3q27_pf_velocity model that need to be resolved. These do not necessarily impact results, but are unsafe access behaviours that should be amended:

  1. Currently the wall phase update reads PhaseF and writes PhaseF. This creates potential race condition as it is a stencil field. To amend this, the solid flag field could be modified to wall phase field value and updated from PhaseF in the wall phase update.
  2. Init_distributions currently saves and writes PhaseF. This doesn't look to be necessary, but could create issues in e.g. boundary cells.

@shkodm this might concern you. But I will either fix when I have time or if you have time feel free to also fix.

@llaniewski
Copy link
Member

@TravisMitchell @shkodm Seems like the model wants to save pnorm in PhaseInit stage, but doesn't set it in Init() function: https://github.com/CFD-GO/TCLB/blob/develop/models/multiphase/d3q27_pf_velocity/Dynamics.c.Rt#L259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants