From 5844f73d314ceba51655b84c73fd7460f2794b82 Mon Sep 17 00:00:00 2001 From: letskuku Date: Mon, 29 Jul 2024 00:18:55 +0900 Subject: [PATCH] =?UTF-8?q?[revert]=20=EC=BD=94=EB=93=9C=20=EC=88=98?= =?UTF-8?q?=EC=A0=95=20=EB=82=B4=EC=97=AD=20=EB=90=98=EB=8F=8C=EB=A6=BC?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../application/ApplicationController.java | 13 ++--- .../ApplicationControllerTest.java | 49 +------------------ 2 files changed, 5 insertions(+), 57 deletions(-) diff --git a/src/main/java/ceos/backend/domain/application/ApplicationController.java b/src/main/java/ceos/backend/domain/application/ApplicationController.java index f7a0f9c6..fa11c758 100644 --- a/src/main/java/ceos/backend/domain/application/ApplicationController.java +++ b/src/main/java/ceos/backend/domain/application/ApplicationController.java @@ -17,8 +17,6 @@ import ceos.backend.domain.application.service.ApplicationService; import ceos.backend.global.common.entity.Part; import io.swagger.v3.oas.annotations.Operation; -import io.swagger.v3.oas.annotations.Parameter; -import io.swagger.v3.oas.annotations.media.Schema; import io.swagger.v3.oas.annotations.tags.Tag; import jakarta.validation.Valid; import java.nio.file.Path; @@ -42,13 +40,10 @@ public class ApplicationController { @Operation(summary = "지원자 목록 보기") @GetMapping public GetApplications getApplications( - @Parameter(schema = @Schema(allowableValues = {"PRODUCT", "DESIGN", "FRONTEND", "BACKEND"})) - @RequestParam(value = "part", required = false, defaultValue = "") Part part, - @Parameter(schema = @Schema(allowableValues = {"PASS", "FAIL"})) - @RequestParam(value = "docPass", required = false, defaultValue = "") Pass docPass, - @Parameter(schema = @Schema(allowableValues = {"PASS", "FAIL"})) - @RequestParam(value = "finalPass", required = false, defaultValue = "") Pass finalPass, - @RequestParam(value = "applicantName", required = false, defaultValue = "") String applicantName, + @RequestParam(value = "part", required = false) Part part, + @RequestParam(value = "docPass", required = false) Pass docPass, + @RequestParam(value = "finalPass", required = false) Pass finalPass, + @RequestParam(value = "applicantName", required = false) String applicantName, @RequestParam("pageNum") int pageNum, @RequestParam("limit") int limit) { log.info("지원자 목록 보기"); diff --git a/src/test/java/ceos/backend/domain/application/ApplicationControllerTest.java b/src/test/java/ceos/backend/domain/application/ApplicationControllerTest.java index e135090c..31ca80f7 100644 --- a/src/test/java/ceos/backend/domain/application/ApplicationControllerTest.java +++ b/src/test/java/ceos/backend/domain/application/ApplicationControllerTest.java @@ -6,9 +6,6 @@ import org.springframework.beans.factory.annotation.Autowired; import org.springframework.boot.test.autoconfigure.web.servlet.AutoConfigureMockMvc; import org.springframework.boot.test.context.SpringBootTest; -import org.springframework.security.authentication.TestingAuthenticationToken; -import org.springframework.security.core.Authentication; -import org.springframework.security.test.web.servlet.request.SecurityMockMvcRequestPostProcessors; import org.springframework.test.web.servlet.MockMvc; import org.springframework.test.web.servlet.request.MockMvcRequestBuilders; import org.springframework.test.web.servlet.result.MockMvcResultMatchers; @@ -23,50 +20,6 @@ public class ApplicationControllerTest { @Test void getApplicationExcelCreationTime() throws Exception { mockMvc.perform(MockMvcRequestBuilders.get("/applications/file/creationtime")) - .andExpect(MockMvcResultMatchers.status().is(403)); - } - - @DisplayName("지원서 목록 보기 API - 필수 아닌 파라미터들 길이 0인 문자열로 처리") - @Test - void getApplicationsWithZeroStrings() throws Exception { - Authentication authentication = new TestingAuthenticationToken(null, null, "ROLE_ADMIN"); - - mockMvc.perform(MockMvcRequestBuilders - .get("/applications?part=&docPass=&finalPass=&applicantName=&pageNum=0&limit=7") - .with(SecurityMockMvcRequestPostProcessors.authentication(authentication))) - .andExpect(MockMvcResultMatchers.status().isOk()); - } - - @DisplayName("지원서 목록 보기 API - 필수 아닌 파라미터들 제외") - @Test - void getApplicationsWithoutRequiredFalse() throws Exception { - Authentication authentication = new TestingAuthenticationToken(null, null, "ROLE_ADMIN"); - - mockMvc.perform(MockMvcRequestBuilders - .get("/applications?pageNum=0&limit=7") - .with(SecurityMockMvcRequestPostProcessors.authentication(authentication))) - .andExpect(MockMvcResultMatchers.status().isOk()); - } - - @DisplayName("지원서 목록 보기 API - enum 타입 영어로 처리") - @Test - void successGetApplications() throws Exception { - Authentication authentication = new TestingAuthenticationToken(null, null, "ROLE_ADMIN"); - - mockMvc.perform(MockMvcRequestBuilders - .get("/applications?part=PRODUCT&docPass=PASS&finalPass=FAIL&applicantName=&pageNum=0&limit=7") - .with(SecurityMockMvcRequestPostProcessors.authentication(authentication))) - .andExpect(MockMvcResultMatchers.status().isOk()); - } - - @DisplayName("지원서 목록 보기 API - enum 타입 한글로 처리 시 예외 발생") - @Test - void failGetApplications() throws Exception { - Authentication authentication = new TestingAuthenticationToken(null, null, "ROLE_ADMIN"); - - mockMvc.perform(MockMvcRequestBuilders - .get("/applications?part=기획&docPass=합격&finalPass=불합격&applicantName=&pageNum=0&limit=7") - .with(SecurityMockMvcRequestPostProcessors.authentication(authentication))) - .andExpect(MockMvcResultMatchers.status().is(400)); + .andExpect(MockMvcResultMatchers.status().is(401)); } }