Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW FEATURE] Define verbose mode for warnings #100

Closed
1 of 2 tasks
tobias-liaudat opened this issue Jan 18, 2021 · 1 comment · Fixed by #101
Closed
1 of 2 tasks

[NEW FEATURE] Define verbose mode for warnings #100

tobias-liaudat opened this issue Jan 18, 2021 · 1 comment · Fixed by #101

Comments

@tobias-liaudat
Copy link
Contributor

Is your feature request related to a problem? Please describe.
This is requested to solve this : issue on the MCCD package.

In summary, the MCCD algorithms uses some optimization algorithms form the ModOpt package. For that the gradient class GradParent() is used from .opt.gradient.py and the function check_npndarray() from .base.types.py throws the warning 'Making input data immutable.' for each instance of the gradient class I have when I run the algorithm.

The main issue is that when the MCCD algorithm is run over a big amount of data, it outputs some big stdout files that are unwanted.

Describe the solution you'd like
It could be possible to add a verbose attribute to the GradParent() class that would be passed to check_npndarray() in order to control its behaviour. As the function check_npndarray() has a verbose variable but it is defaulted to True always in that case.

Are you planning to submit a Pull Request?

  • Yes
  • No

If @sfarrens you're ok with it I can propose a pull request for this.

@sfarrens
Copy link
Contributor

@tobias-liaudat I agree with what you have proposed. You ticked that you are planning a PR for this. If so, I will wait to check it, if not let me know and I will open a PR.

tobias-liaudat added a commit to tobias-liaudat/ModOpt that referenced this issue Jan 19, 2021
@sfarrens sfarrens linked a pull request Jan 19, 2021 that will close this issue
sfarrens pushed a commit that referenced this issue Jan 19, 2021
* Adding verbose attribute to GradParent to solve issue #100

* Improved the attribute docstring

* Fixed correct order of the attributes of GradParent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants