Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary templates created when plotting #53

Open
James-Crean opened this issue May 21, 2018 · 1 comment
Open

Temporary templates created when plotting #53

James-Crean opened this issue May 21, 2018 · 1 comment

Comments

@James-Crean
Copy link
Contributor

When plotting data with vcs-js it looks like temporary templates are being created and are not cleaned up when the websocket is closed. This shows up in vCDAT when plotting some data then refreshing the page. On refresh, vCDAT loads all templates available, which includes the temporary templates created due to plotting.

I believe this may be due to the following line inside of PlotManager.py:

self.dp = self.canvas.plot(*args, ratio="autot")

Specifically, the ratio="autot" part seems to be responsible for creating the template, but there is no code in place to clean it up.

@doutriaux1
Copy link
Contributor

@James-Crean @scottwittenburg I think we need to clear all the canvases before we get the list back. It will remove tem p templates. We do need the aspect ratio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants