Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary template created erroneously #304

Closed
James-Crean opened this issue May 17, 2018 · 1 comment
Closed

Temporary template created erroneously #304

James-Crean opened this issue May 17, 2018 · 1 comment

Comments

@James-Crean
Copy link
Contributor

I have encountered an issue while adding support for editing templates. If a user edits a template everything works as intended including being able to refresh the page. However, if a user plots using the edited template, an identical temporary template gets created. This is not immediately apparent since templates are only populated on load. Once the user refreshes the page, the temporary templates are shown.

I have looked through my code but I only see a single call to create a temporary template, and my testing did not show that line being ran.

Is there something else happening behind the scenes that I am missing, or did I make a mistake in my code?
@doutriaux1 @scottwittenburg

Instructions below for setting up the dev branches for both vCDAT and vcs-js.

  • Make sure you have cloned the vcs and vcdat repos.
  • If you have not already set up a conda environment for vCDAT run ./scripts/setup.sh
  • Source your vCDAT environment. E.g. source activate nightly or conda activate nightly
  • cd into the vcs-js project directory and checkout the add_template_functions branch
  • Run python setup.py install
  • Next, cd into the vcdat project directory and checkout the fix_template_editor branch
  • Run ./scripts/autorun.sh

  • Open your browser and navigate to localhost:5000
  • To recreate the issue, edit the 'default' template, change something such as mean's X value and save
  • Then load a variable of your choice, and drag it into the plotting area.
  • Once the plot loads, refresh the page.
  • You should see a template named something like __template_861925014236853
@James-Crean
Copy link
Contributor Author

Looks like this is not related to the template code, but is instead related to plotting.

See CDAT/vcs-js#53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant