Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement save file guarding #12

Open
conorlawton opened this issue Mar 26, 2023 · 5 comments
Open

Implement save file guarding #12

conorlawton opened this issue Mar 26, 2023 · 5 comments
Labels
feature Adds a new feature semver:patch Requires a patch semver version bump

Comments

@conorlawton
Copy link

Add meta data to saves to prevent them being loaded without the mods present.

  • When the user saves their game, include a list of currently installed mods.
  • When the user loads that save, check all the mods are currently loaded.
  • If a mod on the save's list of mods is not loaded, warn the user that the mod isn't present, but give them the option to force load it anyway.
  • Add a new field to the mod manifest to allow mod authors to mark their mods as not altering save data. This should be opt-out.
@conorlawton conorlawton added the feature Adds a new feature label Mar 26, 2023
@2767mr
Copy link
Member

2767mr commented Mar 26, 2023

Most mods do not actually affect the save file at all

@conorlawton
Copy link
Author

This is for mods that do. Examples are any mods where the player saves in a modded location or saves while using a non-vanilla character model. This would cause the game to error at runtime if those mods aren't present.

@elluminance
Copy link

I'm pretty sure their point was to have this feature be opt-in rather than opt-out - not to not have this feature at all.

@2767mr
Copy link
Member

2767mr commented Mar 26, 2023

It is something that is related to this feature

@conorlawton
Copy link
Author

Opt-out covers more ground than opt-in. It is better for the end user to let the modloader assume that any given mod could alter their save, as this will mitigate the runtime errors resulting from malformed save data.

@lexisother lexisother added the semver:patch Requires a patch semver version bump label Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adds a new feature semver:patch Requires a patch semver version bump
Projects
None yet
Development

No branches or pull requests

4 participants