From 016cf1cc065e1b91e3b143c83d4b3426d54785d7 Mon Sep 17 00:00:00 2001
From: Alejandro-Vega <vegaalejandro15@gmail.com>
Date: Wed, 13 Mar 2024 17:32:48 -0400
Subject: [PATCH] Update submissionQCResults and getSubmission queries and
 types

---
 src/content/dataSubmissions/QualityControl.tsx | 12 ++++++------
 src/graphql/getSubmission.ts                   | 12 ++++++++----
 src/graphql/submissionQCResults.ts             |  4 ++--
 src/types/Submissions.d.ts                     |  5 +++--
 4 files changed, 19 insertions(+), 14 deletions(-)

diff --git a/src/content/dataSubmissions/QualityControl.tsx b/src/content/dataSubmissions/QualityControl.tsx
index ebb4cdcd..4fa852ed 100644
--- a/src/content/dataSubmissions/QualityControl.tsx
+++ b/src/content/dataSubmissions/QualityControl.tsx
@@ -110,13 +110,13 @@ const columns: Column<QCResult>[] = [
   },
   {
     label: "Node Type",
-    renderValue: (data) => <StyledNodeType>{data?.nodeType}</StyledNodeType>,
-    field: "nodeType",
+    renderValue: (data) => <StyledNodeType>{data?.type}</StyledNodeType>,
+    field: "type",
   },
   {
     label: "Submitted Identifier",
-    renderValue: (data) => <StyledBreakAll>{data?.nodeID}</StyledBreakAll>,
-    field: "nodeID",
+    renderValue: (data) => <StyledBreakAll>{data?.submittedID}</StyledBreakAll>,
+    field: "submittedID",
   },
   {
     label: "Severity",
@@ -331,7 +331,7 @@ const QualityControl: FC = () => {
           loading={loading}
           defaultRowsPerPage={20}
           defaultOrder="desc"
-          setItemKey={(item, idx) => `${idx}_${item.batchID}_${item.nodeID}`}
+          setItemKey={(item, idx) => `${idx}_${item.batchID}_${item.submittedID}`}
           onFetchData={handleFetchQCResults}
         />
       </QCResultsContext.Provider>
@@ -339,7 +339,7 @@ const QualityControl: FC = () => {
         open={openErrorDialog}
         onClose={() => setOpenErrorDialog(false)}
         header={null}
-        title={`Validation Issues for ${capitalizeFirstLetter(selectedRow?.nodeType)} Node ID ${selectedRow?.nodeID}.`}
+        title={`Validation Issues for ${capitalizeFirstLetter(selectedRow?.type)} Node ID ${selectedRow?.submittedID}.`}
         errors={allDescriptions}
         errorCount={`${allDescriptions?.length || 0} ${allDescriptions?.length === 1 ? "ISSUE" : "ISSUES"}`}
       />
diff --git a/src/graphql/getSubmission.ts b/src/graphql/getSubmission.ts
index f77bde05..f5866af5 100644
--- a/src/graphql/getSubmission.ts
+++ b/src/graphql/getSubmission.ts
@@ -20,11 +20,15 @@ export const query = gql`
       status
       metadataValidationStatus
       fileValidationStatus
+      fileErrors {
+        title
+        description
+      }
       history {
-          status
-          reviewComment
-          dateTime
-          userID
+        status
+        reviewComment
+        dateTime
+        userID
       }
       conciergeName
       conciergeEmail
diff --git a/src/graphql/submissionQCResults.ts b/src/graphql/submissionQCResults.ts
index ccb30730..ec568927 100644
--- a/src/graphql/submissionQCResults.ts
+++ b/src/graphql/submissionQCResults.ts
@@ -24,11 +24,11 @@ export const query = gql`
       total
       results {
         submissionID
-        nodeType
+        type
         validationType
         batchID
         displayID
-        nodeID
+        submittedID
         severity
         uploadedDate
         validatedDate
diff --git a/src/types/Submissions.d.ts b/src/types/Submissions.d.ts
index b987469d..78f538ad 100644
--- a/src/types/Submissions.d.ts
+++ b/src/types/Submissions.d.ts
@@ -13,6 +13,7 @@ type Submission = {
   status: SubmissionStatus; // [New, In Progress, Submitted, Released, Canceled, Transferred, Completed, Archived]
   metadataValidationStatus: ValidationStatus; // [New, Validating, Passed, Error, Warning]
   fileValidationStatus: ValidationStatus; // [New, Validating, Passed, Error, Warning]
+  fileErrors: ErrorMessage[]; // holds submission level file errors, e.g., extra files in S3 folder
   history: SubmissionHistoryEvent[];
   conciergeName: string; // Concierge name
   conciergeEmail: string; // Concierge email
@@ -174,11 +175,11 @@ type QCResults = {
 
 type QCResult = {
   submissionID: string;
-  nodeType: string;
+  type: string;
   validationType: UploadType;
   batchID: string;
   displayID: number;
-  nodeID: string;
+  submittedID: string;
   severity: "Error" | "Warning"; // [Error, Warning]
   uploadedDate: string; // batch.updatedAt
   validatedDate: string;