MetapropertiesQuery support more query parameters #107
Comments
|
As I do not have permissions to push a branch, someone else needs to do this, in the meantime I work my my local fork. |
|
@colinmanning Feel free to create a PR! Our team will review the code and if it's up to our standards we will merge and release a new version of the SDK. We really appreciate our users contributing to the SDK's. |
|
@TimBloembergen I don't have permission to push my branch. Ca you sort that for me. I get this error: ERROR: Permission to Bynder/bynder-java-sdk.git denied to colinmanning. |
Hey @colinmanning what do you mean by I ask this because I just tested creating a fork > commiting > creating the PR and it worked fine 🤔 Thanks! |
|
@dylanmartins - OK, I am not using GitHub workflows much at the moment, I cloned master, made a local branch and tried to push it to make a PR - it's what we do using GitLab. Anyway, I will fork as you suggest later then and go that way. The code changes are trivial, just replicating the way properties are created in the class already, so it's a bit of monkey coding. I will do this later when I get time. |
…ss MetapropertiesQuery to support getting all metaproperties without options and retrieving individual metaproperties (with options if needed)
#109) * Implement Issue #107 - add properties "options" and "id" to class MetapropertiesQuery to support getting all metaproperties without options and retrieving individual metaproperties (with options if needed) * replace property "id" with "ids" in MetapropertyQuery to ensure a dictionary (Map) is returned, and so not break the retrofix introspection. Add basic unit tests for MetapropertyQuery. --------- Co-authored-by: Colin Manning <[email protected]>
|
@colinmanning Merged your changes into master and created a new release version for |
Quick heads up as today is my last day working at zetcom, it would be good to know if 2.2.19 will be available today in Maven Central. If not, I have instructed my team on the issue, and they can work with the local fork. As the formk is on my private GitHub account, I will not delete it for now. |
|
@colinmanning Most likely not, looks like GitHub Actions was disabled for this repo which is needed for us to deploy to Maven Central. Until this is resolved, we're dependent on the action back up and running before it reaches Maven Central. |
|
@colinmanning GitHub actions were re-enabled. Deleted and published 2.2.19, release job ran successfully. Version 2.2.19 published at https://central.sonatype.com/artifact/com.bynder/bynder-java-sdk. Feel free to let your old team know this is updated and verify if it's working, thanks. |
When making a request for all metaproperties, the call can timeout if some metaproperties have large numbers of options (e.g. a complex taxonomy).
To get around this, it should be possible to query metaproperties without options (options=0) and then only request the options for metaproperties of interest. This can be done easily via the REST calls, but not currently via the Java SDK.
An easy solution is to add the properties "options" and "id", so the relevant REST calls can be made.
I have made a branch to implement this and I can push it and create pull request.
The text was updated successfully, but these errors were encountered: