-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance adding urls in video collection template #376
Comments
Thanks @yadav-rahul for your interest in this. I have done some part of it. @croozeus @opticod waiting for your views on this. Shall I continue work on this and create PR? |
@vishwesh3, Its a real issue. We should fix this. Lets discuss the implementation a bit and choose the best one: What will be next step after you click the "Add this video" ? |
We will add menu item with
where and This So when Add this video is clicked Something like this. In this sample I am showing toast on selecting Add this video, in our toolkit app, will add selected video in our list. Also in sample I have used Hello button to launch custom tab, in our toolkit app we can show a button at the right of the on clicking above button we can show a dialog containg list of all sites whose videos are supported in our app (youtube, vimeo, dailymotion), and on selecting this option launch customtab with selected site. @opticod should I proceed with this? |
Cool, you can proceed |
Observed Behaviour
To add items we have to enter link in the dialog.
Issue
It is difficult to copy url's and paste in the dialog.
Solution
Use CustomTabs
Approach
Add a Browse button in the dialog. On clicking that open CustomTabs with action button Add this video. On clicking this action (Add this video) video will be added in the template.
The text was updated successfully, but these errors were encountered: