-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deduplicate elements: ActiveDehumidification through EnergySellRate #323
Comments
All of these instances were found to be identical. A base level element was created by the same name and all instances were converted into references: ActiveDehumidification |
These instances were no longer duplicated as a result of consolidating one of the previously listed elements: AnnualSavingsByFuel |
These instances were identical save for minor differences in documentation. In each instance a more generic documentation was provided after consolidating into a base level element: CoolingSourceID
EndTimestamp
EndUse
|
The remaining instances require some changes: AdvancedPowerStrip
AssemblyType
Building
CBECS
Capacity
ClimateZone
CommunicationProtocol
Control
ControlSensor
ControlStrategy
ControlSystemTypes
Controls
ConveyanceSystems
|
Edit: updated previous comment; after doing some more research it looks like my original idea for |
After chatting with @nllong we decided that cases where the type is basically the same (but still slightly different) it's probably OK to keep the duplicate name. E.g. AdvancedPowerStrip |
Moved remaining duplicates to #356 |
The schema redefines elements that should technically be references to a single element/type.
For each of the elements below:
ignored_dupes
list in validation_spec.rb.Below are the duplicated element names and their current line numbers at 37086c4
The text was updated successfully, but these errors were encountered: