Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OFFSEASON: Rewrite most of YAGSL in C++ then use JNI #3

Open
thenetworkgrinch opened this issue Mar 9, 2023 · 5 comments
Open

OFFSEASON: Rewrite most of YAGSL in C++ then use JNI #3

thenetworkgrinch opened this issue Mar 9, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@thenetworkgrinch
Copy link
Contributor

YAGSL currently runs slower than it should because of slow java calls and jumping. Most of YAGSL can and should be rewritten into C++ then mapped to their current locations using JNI. This will also expand YAGSL to support C++ teams and be the only "mainstream" swerve library that supports C++.

When this change is made development will take place solely in the vendordep repository (YAGSL-Lib) due to it's support of JNI compilation and delivery to teams. This development will only take place after v1 released. All further development will be done in C++ if possible.

@thenetworkgrinch thenetworkgrinch self-assigned this Mar 9, 2023
@thenetworkgrinch thenetworkgrinch added enhancement New feature or request help wanted Extra attention is needed labels Mar 9, 2023
@thenetworkgrinch thenetworkgrinch transferred this issue from BroncBotz3481/YAGSL-Example Mar 9, 2023
@DanPeled
Copy link

Im currently working on this exact thing, havent done any JNI stuff tho, only implementation of the classes in C++, like 30% done

@thenetworkgrinch
Copy link
Contributor Author

I can invite you to the in dev version rn, it hasnt been touched in a few months though

@DanPeled
Copy link

DanPeled commented Aug 28, 2024

Ive just been working here: https://github.com/DanPeled/YAGSL-CPP/tree/2024
i think ill stick with my repo, mostly interested to learn how YAGSL works by myself

@thenetworkgrinch
Copy link
Contributor Author

I just shared the development repo with you so you can read and use it.

@DanPeled
Copy link

DanPeled commented Aug 28, 2024

Tbh seems like mine is in a somewhat more developed state currently, ill look into it tho, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants