Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the @ComponentScan in @FrameworkControllerScan configuration to an ImportBeanDefinitionRegistrar #2

Open
phillipuniverse opened this issue Sep 11, 2018 · 0 comments

Comments

@phillipuniverse
Copy link
Contributor

Since we are hijacking @ComponentScan to utilize @FrameworkControllerScan, this prevents a user from using it alongside any other @ComponentScan, including an @SpringBootApplication class.

Instead, a user is required to create a static inner class or @Import another @Configuration class that contains the @FrameworkControllerScan.

This represents work towards dynamically registering beans via an ImportBeanDefinitionRegistrar. Some work has already been done towards this effort at import-registrar. The challenge is that we need to build our own BeanDefinition from the class itself and don't have a lot of examples to rely on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant