Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release is done before artifacts are uploaded #28

Open
maxandersen opened this issue Dec 26, 2019 · 1 comment
Open

Release is done before artifacts are uploaded #28

maxandersen opened this issue Dec 26, 2019 · 1 comment

Comments

@maxandersen
Copy link

When using this plug-in the Only artifacts listed in notifications are the source zip and tar. Additional artifacts are only visible on the release page.

Feels like it's releases immediately rather than create draft releases then upload artifacts and then mark as releases.

@BreadMoirai
Copy link
Owner

GitHub doesn't assign a tag to the release until it's published for some reason and so there isn't any way for us to figure out what release we want to upload artifacts to. This normally wouldn't be a problem for the simple use case as we do get the link to the release when we create it initially but for more complex systems that upload artifacts using a CI on a different process, we would have to do something janky like just looking for the most recent draft. Not sure the best way to approach this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants