Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Text.of_bytes_stream to be consistent with File.of_path #110

Open
jasone opened this issue Feb 24, 2021 · 1 comment
Open

Refactor Text.of_bytes_stream to be consistent with File.of_path #110

jasone opened this issue Feb 24, 2021 · 1 comment
Labels
refactor

Comments

@jasone
Copy link
Contributor

jasone commented Feb 24, 2021

Text.of_bytes_stream takes a path parameter of type string, but it should probably take path as Bytes.Slice.t, as does File.of_path.
@jasone
Copy link
Contributor Author

jasone commented Feb 24, 2021

This should be done as part of #88.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jasone