-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for custom deeplink image #58
Comments
Hi @deficts, could you provide additional detail as what you are referring too? |
So, in our app we implemented the deeplinking for sharing posts, that works well, but we want to be able to set a custom image in our deeplinks (right now when you share a deeplink the image shown, for example, in whatsapp is the icon of the app, but we want that image to be the image of the post). Tell me if im wrong but it is possible by customizing the contentImageUrl variable right? but in capacitor we are not able to access this variables, right? @jf-branch |
Thank you for the clarification @deficts. You can still do this through the capacitor SDK as well. i.e
|
Great! are these properties available using the showShareSheet method too? Thanks for the clarification!! @jf-branch |
Also, I think the $og_image_url property is not defined in this SDK see: https://github.com/BranchMetrics/capacitor-branch-deep-links/blob/master/src/definitions.ts#L27-L36 |
@deficts yes it will work for showShareSheet as well. I'm nearly certain it doesnt have to be defined in definitions.ts. |
I think the property must be included in definitions otherwise the project won't compile @jf-branch |
Got it! Thanks for testing! I'll create an internal ticket to get this updated. |
Thank you for the attention and support!!! |
@deficts I'm gonna talk to the engineer on this, but I'm thinking about just making BranchShortURLProperties a [String:String] object, because the API can accept any key value pair within the nested 'data' dictionary as long as its String:String. https://help.branch.io/developers-hub/docs/deep-linking-api#sample-request---create |
That sounds good, I'll keep an eye for any update, thanks again! |
Any updates on this? |
@jf-branch any update on this? I'm looking for this as well, but running into the same typescript issue. |
I'm aware that is possible to add a custom url image in native plugins, I think it's an important feature for us capacitor users.
The text was updated successfully, but these errors were encountered: