parser: fixed issue with optional members in interfaces becoming required in ActionScript

Author: joshtynjala

source/parser.ts

@@ -2255,6 +2255,10 @@ export default class
 			//this property can be ignored
 			return null;
 		}
+		if(propertyDeclaration.questionToken)
+		{
+			return null;
+		}
 		let isStatic = false;
 		if(propertyDeclaration.modifiers)
 		{
@@ -2281,6 +2285,10 @@ export default class
 			//this property can be ignored
 			return;
 		}
+		if(propertyDeclaration.questionToken)
+		{
+			return null;
+		}
 		let isStatic = false;
 		if(propertyDeclaration.modifiers)
 		{
@@ -2441,6 +2449,10 @@ export default class
 			//this method can be ignored
 			return null;
 		}
+		if(functionDeclaration.questionToken)
+		{
+			return null;
+		}
 		let isStatic = false;
 		if(functionDeclaration.modifiers)
 		{
@@ -2468,6 +2480,10 @@ export default class
 			//this method can be ignored
 			return;
 		}
+		if(functionDeclaration.questionToken)
+		{
+			return null;
+		}
 		let typeParameters = this.populateTypeParameters(functionDeclaration);
 		let isStatic = false;
 		if(functionDeclaration.modifiers)

spec/fixtures/interface-optional-members.d.ts

@@ -1,10 +1,5 @@
 export interface InterfaceWithOptionalMembers
 {
-	method1(): number;
-	method2?(): boolean;
-}
-
-export class ClassImplementsInterfaceWithOptionalMembers implements InterfaceWithOptionalMembers
-{
-	method1();
+	method1?(): number;
+	method2(): boolean;
 }

spec/parser/parser-spec.ts

@@ -459,6 +459,20 @@ describe("An interface", () =>
 		let as3MethodType = <as3.TypeDefinition> as3.getDefinitionByName("Number", symbols);
 		expect(method.type).toBe(as3MethodType);
 	});
+	it("must skip optional methods", () =>
+	{
+		let symbols = parser.parse(["spec/fixtures/interface-optional-members.d.ts"]).definitions;
+		let as3Interface = <as3.TypeDefinition> as3.getDefinitionByName("InterfaceWithOptionalMembers", symbols);
+		expect(as3Interface).not.toBeNull();
+		expect(as3Interface.methods.length).toBe(1);
+		let method = as3Interface.methods[0];
+		expect(method).not.toBeNull();
+		expect(method.name).toBe("method2");
+		expect(method.accessLevel).toBeNull();
+		expect(method.isStatic).toBe(false);
+		let as3MethodType = <as3.TypeDefinition> as3.getDefinitionByName("Boolean", symbols);
+		expect(method.type).toBe(as3MethodType);
+	});
 	it("may extend another interface", () =>
 	{
 		let symbols = parser.parse(["spec/fixtures/interface-extends-interface.d.ts"]).definitions;