You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When calling acceptFulfillment an _approverId is passed in as a parameter. That is then passed to the modifier to determine if the user is authorized to accept fulfillments. The modifier looks like this:
I think it is weird that if msg.sender == controller it doesn't matter what the approverId is. I believe a better approach would be to overload the function with two different signatures where one could be called with the approveId and one could be called without.
The text was updated successfully, but these errors were encountered:
When calling
acceptFulfillment
an_approverId
is passed in as a parameter. That is then passed to the modifier to determine if the user is authorized to accept fulfillments. The modifier looks like this:I think it is weird that if
msg.sender == controller
it doesn't matter what the approverId is. I believe a better approach would be to overload the function with two different signatures where one could be called with the approveId and one could be called without.The text was updated successfully, but these errors were encountered: