Coding style regarding try catch block

[tylorngo]

Hi,

So I am just asking a small question regarding coding style. Please let me know if my question is fine in this discussion or I should post it somewhere else.

In the source code:

try
                {
                    var computerIPv6 = Models.Network.NetworkInterface.DetectLocalIPAddressBasedOnRouting(IPAddress.Parse(SettingsManager.Current.Dashboard_PublicIPv6Address));
                    string routerIPv6 = Models.Network.NetworkInterface.DetectGatewayBasedOnLocalIPAddress(computerIPv6).ToString();

                    if (ct.IsCancellationRequested)
                        ct.ThrowIfCancellationRequested();

                    RouterIPv6 = routerIPv6;
                    RouterIPv6State = ConnectionState.OK;
                }
                catch (Exception)
                {
                    RouterIPv6 = "-/-";
                    RouterIPv6State = ConnectionState.Critical;
                }

My usual style:

try
                {
                    IPAddress publicIPv6Address = IPAddress.Parse(SettingsManager.Current.Dashboard_PublicIPv6Address);
                    if (publicIPv6Address != null)
                    {
                        var computerIPv6 = Models.Network.NetworkInterface.DetectLocalIPAddressBasedOnRouting(publicIPv6Address);

                        if (ct.IsCancellationRequested)
                            ct.ThrowIfCancellationRequested();

                        ComputerIPv6 = (computerIPv6 == null) ? "-/-" : computerIPv6.ToString();
                        ComputerIPv6State = (computerIPv6 == null) ? ConnectionState.Warning : ConnectionState.OK;
                    }
                    else
                    {
                        ComputerIPv6 = "-/-";
                        ComputerIPv6State = ConnectionState.Warning;
                    }
                    
                }
                catch (Exception)
                {
                    ComputerIPv6 = "-/-";
                    ComputerIPv6State = ConnectionState.Critical;
                }

Normally I will try to handle as much exception as possible. In this case, as I am expecting IPv6 address to be null (or not enabled by user) and handle that, should I just put it in the try block to assign it correctly, and let the code catch other Exception? Or there won't be other exceptions that are more serious than null IP address?

I do not set IPv6 on my local network, so it's null, and when debugging, the program threw the Exception into my face 3 times in a row...

Thank you in advance.

[BornToBeRoot]

I think your style is better. The more errors are treated, the more accurate the message. Whether this is now a warning or critical I do not know yet exactly.

I also need to rework the IPv6 function because it's not working properly. Improvements also gladly as PR :)