-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow optionally to increase Boltz miner fee for lockup transaction #326
Comments
is any update on this feature? |
Hi Alex, thanks for checking in. Still working on it. If you are up for testing this feature on testnet I'd ping you once we have sth up? |
Sure. I would like to test.
… On May 26, 2023, at 3:12 AM, Armur Bitcoin ***@***.***> wrote:
Hi Alex, thanks for checking in. Still working on it. If you are up for testing this feature on testnet I'd ping you once we have sth up?
—
Reply to this email directly, view it on GitHub <#326 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABCJHF3QAPWE6GWO6GJKEFTXIB6Y5ANCNFSM6AAAAAAXPIAK5M>.
You are receiving this because you commented.
|
Another option is to only allow a custom miner fee for the claim tx in reverse swaps. |
@armurbalda during high fee rate environments such as the recent one driven by ordinals inscriptions seem like it inevitably "leads to getting your funds into the mempool with unreasonably low rates that are doomed to timeout". Especially since the rates may increase near exponentially from block to block. I agree with your idea about limiting a user's choice between low-high feerates from mempool.space but that might not be enough during these environments. Perhaps during volatile environments you should further limit the user's choice to at least the high priority fee rate or greater. My use case allows for assigning fees aggressively targeting the next block for both lockup & claim txs. My idea would be to assign a fee rate ~1.5 the current high priority estimation from mempool.space during such environments. My use case targets consistently settling the swap in under an hour 24/7. To do this requires confirmations in 1-2 blocks for both lockup & claim txs. I'm willing to assign higher fees than boltz might for each tx to ensure this. Seems like it could work for boltz to limit user assigned fee rates to those above certain values given certain conditions. To emphasize, there are use cases such as mine that put importance on allowing user defined fees for both claim & lockup txs in reverse swaps. Thanks for your consideration! |
Got it! That actually sounds like a nice way to start out. Only allow increase of fees (> mempool's @michael1011 wdyt? |
So two things seem viable for now:
|
As per comment below we settled on only allowing users to optionally increase miner fees for lockup. Backend should add a new optional parameter to
/createswap
to allow for this.The text was updated successfully, but these errors were encountered: