Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow optionally to increase Boltz miner fee for lockup transaction #326

Open
armurbalda opened this issue Apr 28, 2023 · 8 comments
Open
Assignees
Labels
enhancement New feature or request P2

Comments

@armurbalda
Copy link
Contributor

armurbalda commented Apr 28, 2023

As per comment below we settled on only allowing users to optionally increase miner fees for lockup. Backend should add a new optional parameter to /createswap to allow for this.

@armurbalda armurbalda added feature enhancement New feature or request and removed feature labels Apr 28, 2023
@slowisfast168
Copy link

is any update on this feature?

@armurbalda
Copy link
Contributor Author

Hi Alex, thanks for checking in. Still working on it. If you are up for testing this feature on testnet I'd ping you once we have sth up?

@armurbalda armurbalda added P1 P2 and removed P1 labels May 26, 2023
@slowisfast168
Copy link

slowisfast168 commented May 26, 2023 via email

@armurbalda
Copy link
Contributor Author

Update: we still didn't settle on how to prevent users from getting our funds into the mempool with unreasonably low rates that are doomed to timeout.

A first approach would be to e.g. limit the choice to values between mempool's low and high prio fee rate:
image

@armurbalda
Copy link
Contributor Author

Another option is to only allow a custom miner fee for the claim tx in reverse swaps.

@gavatron1010
Copy link

@armurbalda during high fee rate environments such as the recent one driven by ordinals inscriptions seem like it inevitably "leads to getting your funds into the mempool with unreasonably low rates that are doomed to timeout". Especially since the rates may increase near exponentially from block to block. I agree with your idea about limiting a user's choice between low-high feerates from mempool.space but that might not be enough during these environments. Perhaps during volatile environments you should further limit the user's choice to at least the high priority fee rate or greater. My use case allows for assigning fees aggressively targeting the next block for both lockup & claim txs. My idea would be to assign a fee rate ~1.5 the current high priority estimation from mempool.space during such environments. My use case targets consistently settling the swap in under an hour 24/7. To do this requires confirmations in 1-2 blocks for both lockup & claim txs. I'm willing to assign higher fees than boltz might for each tx to ensure this. Seems like it could work for boltz to limit user assigned fee rates to those above certain values given certain conditions. To emphasize, there are use cases such as mine that put importance on allowing user defined fees for both claim & lockup txs in reverse swaps. Thanks for your consideration!

@armurbalda
Copy link
Contributor Author

Got it! That actually sounds like a nice way to start out. Only allow increase of fees (> mempool's High Priority).

@michael1011 wdyt?

@armurbalda
Copy link
Contributor Author

armurbalda commented Jul 26, 2023

So two things seem viable for now:

  • freely customizable claim fee for reverse swaps. E.g. Thunderhub's implementation of Boltz Swaps already allows this. This is on web app/client side. I'd open an issue on web app side, and take this out of here? @michael1011
  • allow to pay more than Boltz's suggestion for the miner fee, first step would be for API to take a parameter for overpayment from web app/client to apply on miner fee used. Nominal in sats/vbyte to be added on top is best I guess? This would be what this issue is about then. @michael1011

@kilrau kilrau changed the title Accept custom miner fee Allow optionally to increase Boltz miner fee for lockup transaction Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2
Projects
None yet
Development

No branches or pull requests

4 participants