Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCM depth indicator #2

Open
acapet opened this issue Nov 15, 2021 · 0 comments
Open

DCM depth indicator #2

acapet opened this issue Nov 15, 2021 · 0 comments

Comments

@acapet
Copy link
Collaborator

acapet commented Nov 15, 2021

Hi !

I have an issue with the indicator DCM depth.

According to the dedicated wiki page (and to the .xml files I'm using), the python formula appears as :

([MODEL_DEF])[:,152:192].mean(axis=0).argmax(axis=0)

where MODEL_DEF is your Tot Chl variable.

  1. This doesn't provide the depth, but the index of the depth.
  2. I'd rather move the time average.
  3. And in fact, I'd also get rid of the restriction on the possible depth range..

Only 1 is strictly essential for the relevance of 3.2, since depth-index relationship is non-linear.

I therefore propose something like :

h[0,([MODEL_DEF])[:,:].argmax(axis=1)]].mean(axis=0) 

ie. assuming h changes with time are minor. Else, something like

[ h[t,i] for t,i in zip(time, [MODEL_DEF])[:,:].argmax(axis=1)].mean(axis=0)

if this is tractable within the parsac environment.

It could be that this error is only in my .xml files, but supposedly those are originated from common sources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant