core: fix most lints flagged by raco review

Author: Bogdanp

gui-easy-lib/gui/easy/color.rkt

@@ -1,7 +1,7 @@
 #lang racket/base
 
 (require racket/class
-         racket/contract
+         racket/contract/base
          racket/fixnum
          (prefix-in gui: racket/gui))
 
@@ -14,7 +14,7 @@
 
 (define color
   (case-lambda
-    [(color)
+    [(color) ;; noqa
      (if (fixnum? color)
          (make-object gui:color%
                       (fxand (fxrshift color 24) #xFF)

gui-easy-lib/gui/easy/contract.rkt

@@ -1,6 +1,7 @@
 #lang racket/base
 
-(require racket/contract
+(require racket/contract/base
+         racket/contract/combinator
          (prefix-in gui: racket/gui)
          "private/observable.rkt")
 
@@ -63,7 +64,8 @@
     [else (or/c c (obs/c c))]))
 
 (module+ test
-  (require rackunit)
+  (require racket/contract/region
+           rackunit)
 
   (test-case "(maybe-obs/c any/c)"
     (check-eq? (maybe-obs/c any/c) any/c))

gui-easy-lib/gui/easy/font.rkt

@@ -1,7 +1,7 @@
 #lang racket/base
 
 (require racket/class
-         racket/contract
+         racket/contract/base
          racket/draw
          (prefix-in gui: racket/gui)
          racket/string)
@@ -12,14 +12,14 @@
   [font* (font/c (or/c string? (listof string?)) (or/c #f (is-a?/c gui:font%)))]))
 
 (define (font/c name/c res/c)
-  (->* (name/c (real-in 0 1024.0))
-       (#:family gui:font-family/c
+  (->* [name/c (real-in 0 1024.0)]
+       [#:family gui:font-family/c
         #:style gui:font-style/c
         #:weight gui:font-weight/c
         #:underline? any/c
         #:smoothing gui:font-smoothing/c
         #:hinting gui:font-hinting/c
-        #:size-in-pixels? any/c)
+        #:size-in-pixels? any/c]
        res/c))
 
 (define (font face size

gui-easy-lib/gui/easy/observable.rkt

@@ -1,13 +1,13 @@
 #lang racket/base
 
-(require racket/contract
+(require racket/contract/base
          "private/observable.rkt")
 
 (provide
  (contract-out
-  [obs (->* (any/c)
-            (#:name symbol?
-             #:derived? boolean?)
+  [obs (->* [any/c]
+            [#:name symbol?
+             #:derived? boolean?]
             obs?)]
   [obs? (-> any/c boolean?)]
   [obs-rename (-> obs? symbol? obs?)]
@@ -17,20 +17,20 @@
   [obs-set! (-> obs? any/c void?)]
   [obs-peek (-> obs? any/c)]
   [obs-map (-> obs? (-> any/c any/c) obs?)]
-  [obs-filter (->* (obs? (-> any/c any/c)) (any/c) obs?)]
-  [obs-filter-map (->* (obs? (-> any/c any/c)) (any/c) obs?)]
+  [obs-filter (->* [obs? (-> any/c any/c)] [any/c] obs?)]
+  [obs-filter-map (->* [obs? (-> any/c any/c)] [any/c] obs?)]
   [obs-combine (-> procedure? obs? obs? ... obs?)]
-  [obs-debounce (->* (obs?)
-                     (#:duration exact-nonnegative-integer?)
+  [obs-debounce (->* [obs?]
+                     [#:duration exact-nonnegative-integer?]
                      obs?)]
-  [obs-throttle (->* (obs?)
-                     (#:duration exact-nonnegative-integer?)
+  [obs-throttle (->* [obs?]
+                     [#:duration exact-nonnegative-integer?]
                      obs?)]
-  [chaperone-obs (->* (obs?)
-                      (#:ref (or/c #f (-> obs? any/c any/c))
-                       #:set (or/c #f (-> obs? any/c any/c)))
+  [chaperone-obs (->* [obs?]
+                      [#:ref (or/c #f (-> obs? any/c any/c))
+                       #:set (or/c #f (-> obs? any/c any/c))]
                       obs?)]
-  [impersonate-obs (->* (obs?)
-                        (#:ref (or/c #f (-> obs? any/c any/c))
-                         #:set (or/c #f (-> obs? any/c any/c)))
+  [impersonate-obs (->* [obs?]
+                        [#:ref (or/c #f (-> obs? any/c any/c))
+                         #:set (or/c #f (-> obs? any/c any/c))]
                         obs?)]))

gui-easy-lib/gui/easy/private/observable.rkt

@@ -91,7 +91,7 @@
   (impersonate-struct o
                       obs-value-box
                       (and val-ref
-                           (lambda (o bx)
+                           (lambda (o bx) ;; noqa
                              (do-impersonate-box
                               bx
                               (lambda (_ v) (val-ref o v))
@@ -100,12 +100,13 @@
                       #f ; witness
                       obs-update-value-box!
                       (and val-set
-                           (λ (_ update-proc)
+                           (λ (o update-proc) ;; noqa
                              (do-impersonate-procedure
                               update-proc
                               (λ (proc)
-                                (values (lambda (v) (val-set o v))
-                                        proc)))))
+                                (values
+                                 (λ (v) (val-set o v))
+                                 proc)))))
                       set-obs-update-value-box!!
                       #f))
 
@@ -126,7 +127,7 @@
                       impersonate-procedure
                       val-ref
                       val-set))
-  
+
 (define (obs-rename o name)
   (impersonate-struct o
                       obs-name

gui-easy-lib/gui/easy/private/renderer.rkt

@@ -52,7 +52,7 @@
       (begin0 root
         (do-add-dependencies (send tree dependencies) tree root)))
 
-    (define/public (add-dependencies deps tree root)
+    (define/public (add-dependencies deps tree root) ;; noqa
       (do-add-dependencies deps tree root))
 
     (define/public (remove-dependencies s)
@@ -68,7 +68,7 @@
              (send tree destroy root))
            (set! root #f)))))
 
-    (define (do-add-dependencies deps tree root)
+    (define (do-add-dependencies deps tree root) ;; noqa
       (define s
         (dependency-set deps (for/list ([dep (in-list deps)])
                                (define (proc v)

gui-easy-lib/gui/easy/private/view/common.rkt

@@ -2,7 +2,7 @@
 
 (require (for-syntax racket/base
                      racket/format
-                     syntax/parse)
+                     syntax/parse/pre)
          "../logger.rkt"
          "../observable.rkt")
 

gui-easy-lib/gui/easy/private/view/menu.rkt

@@ -1,7 +1,7 @@
 #lang racket/base
 
 (require racket/class
-         racket/contract
+         racket/contract/base
          (prefix-in gui: racket/gui)
          racket/list
          "../observable.rkt"

gui-easy-lib/gui/easy/private/view/window.rkt

@@ -1,7 +1,7 @@
 #lang racket/base
 
 (require racket/class
-         racket/contract
+         racket/contract/base
          (prefix-in gui: racket/gui)
          racket/list
          racket/match

gui-easy-lib/gui/easy/renderer.rkt

@@ -1,7 +1,7 @@
 #lang racket/base
 
 (require racket/class
-         racket/contract
+         racket/contract/base
          (prefix-in gui: racket/gui)
          "private/renderer.rkt"
          "private/view.rkt")
@@ -12,8 +12,8 @@
   [embed (-> (is-a?/c gui:area<%>)
              (is-a?/c view<%>)
              (is-a?/c renderer<%>))]
-  [render (->* ((is-a?/c window-view<%>))
-               ((or/c (is-a?/c renderer<%>) #f))
+  [render (->* [(is-a?/c window-view<%>)]
+               [(or/c (is-a?/c renderer<%>) #f)]
                (is-a?/c renderer<%>))]
   [render-popup-menu (-> (is-a?/c renderer<%>)
                          (is-a?/c popup-menu-view<%>)