Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config test representation #8

Open
halfow opened this issue Apr 5, 2020 · 1 comment
Open

config test representation #8

halfow opened this issue Apr 5, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@halfow
Copy link

halfow commented Apr 5, 2020

I modified run.py:12 with [testlib.test_bench("tb_test1").test("test1").add_config(f"conf{n}") for n in range(0, 3)].

This adds some more configurations so I could see how they affected the test explorer outline and UI injected in the testbench (.vhd) of the test case with multiple configs.

It looks fine and is still really intuitive.

All though I would prefer if the test explorer out line would create tree for test cases with multiple configs.

Today:

  • testlib
    ...
    • tb_test0
      • conf0.test1
      • conf1.test1
      • conf2.test1
      • test2
      • test3
        ...

Proposed:

  • testlib
    ...
    • tb_test0
      • test1
        • conf0
        • conf1
        • conf2
      • test2
      • test3
        ...
@halfow halfow changed the title config test representation tag:enhancement config test representation lable:enhancement Apr 5, 2020
@Bochlin
Copy link
Owner

Bochlin commented Apr 5, 2020

That was my original intention, the problem is that there is no way for the extension to reliably determine the configuration name.

VUnit names the tests library.testbench.[configuration.]testname and since both configuration and testname are allowed to contain "." it is not possible to say "if name has four parts then third part is configuration name".

In order to group in the way you propose, the exported json from VUnit needs to support at least a field naming the configuration (if any). It may still be an improvement though to add one more level of hierarchy or allowing the user to set the maximum hierarchy depth, then at least the configurations would be grouped.

@Bochlin Bochlin changed the title config test representation lable:enhancement config test representation Apr 5, 2020
@Bochlin Bochlin added the enhancement New feature or request label Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants