Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ctrl+enter to submit the password on the login screen #80

Open
essential-randomness opened this issue Sep 23, 2022 · 0 comments
Open

Allow ctrl+enter to submit the password on the login screen #80

essential-randomness opened this issue Sep 23, 2022 · 0 comments
Labels
📦 boba-frontend An issue that involves the boba-frontend repository 🌤 Easy 🐞 Feature Add a new feature or improve an existing one 🦵 Good first issue Good for newcomers to the project ⏩ Ready to implement 💪 Self-contained The task doesn't have broad repercussions on the BobaBoard codebase 🛶 Small

Comments

@essential-randomness
Copy link
Collaborator

Note: I think the "right" way to do this is to change the login popup to use a <form> tag and have the Login button be "type="submit"" (we also probably need to preventDefault on the form submit event). We haven't done this before (my bad for bad development practices), so I might be wrong, but we should attempt to get it to work that way.

I swear this is less complex than it sounds.
@essential-randomness essential-randomness added ⏩ Ready to implement 🦵 Good first issue Good for newcomers to the project 🌤 Easy 📦 boba-frontend An issue that involves the boba-frontend repository 🛶 Small 💪 Self-contained The task doesn't have broad repercussions on the BobaBoard codebase 🐞 Feature Add a new feature or improve an existing one labels Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
📦 boba-frontend An issue that involves the boba-frontend repository 🌤 Easy 🐞 Feature Add a new feature or improve an existing one 🦵 Good first issue Good for newcomers to the project ⏩ Ready to implement 💪 Self-contained The task doesn't have broad repercussions on the BobaBoard codebase 🛶 Small
Projects
No open projects
The annoyances-be-gone sprint (🛫October 1st 🛬November 14th)
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@essential-randomness