Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctrl+click should open links in new tab (similar to mousewheel click) #71

Closed
essential-randomness opened this issue May 8, 2021 · 2 comments
Assignees
Labels
📦 boba-components An issue that involves the boba-components repository 🌤 Easy 🚧 To sort Auto-added to all issues; removed after issues have been reviewed and classified

Comments

@essential-randomness
Copy link
Collaborator

[Components]: ctrl+click should open links in new tab (similar to mousewheel click)

@essential-randomness essential-randomness added the 📦 boba-components An issue that involves the boba-components repository label May 8, 2021
@riazaia riazaia added the 🚧 To sort Auto-added to all issues; removed after issues have been reviewed and classified label Sep 16, 2022
@essential-randomness essential-randomness transferred this issue from BobaBoard/issues Sep 17, 2022
@essential-randomness
Copy link
Collaborator Author

We can fix it by adding a condition in ActionLink that checks whether shift or other modifier keys are pressed and does not prevent default in that case: https://github.com/BobaBoard/boba-components/blob/main/src/buttons/ActionLink.tsx#L85

@essential-randomness
Copy link
Collaborator Author

essential-randomness commented Jul 25, 2023

Fixed by #123 and added to more frontend places by BobaBoard/boba-frontend#143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 boba-components An issue that involves the boba-components repository 🌤 Easy 🚧 To sort Auto-added to all issues; removed after issues have been reviewed and classified
Development

No branches or pull requests

2 participants