Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Post component to render hidden thread placeholder as needed #63

Open
virtuous-cat opened this issue Jun 22, 2022 · 0 comments
Open
Labels
📦 boba-components An issue that involves the boba-components repository 🛠 CSS 🌤 Easy 🎨 Frustration busters Make BobaBoard a pleasure to use 🛠 React Is familiar with the React Framework 🛶 Small

Comments

@virtuous-cat
Copy link
Member

virtuous-cat commented Jun 22, 2022

(Ms boba has edited this)

On this updated design, HiddenThread should wrap the original Post as a child, like this:

<HiddenThread /* props */>
  <Post /* props */ />
</HiddenThread>

By default, HiddenThread should not display Post unless its hidden prop equals false. Then HiddenThread should wrap Post with additional UI (see attachment).

One (slight) difficulty is that HiddenThread should avoid displaying the wrapped Post's content notices since they will already be displayed by HiddenThread. This can be done by cloning the Post child and passing a new tags prop that has no content notices.

image

The buttons at the top should follow down the post as the user scrolls.

@essential-randomness essential-randomness added the 🚧 To sort Auto-added to all issues; removed after issues have been reviewed and classified label Sep 16, 2022
@virtuous-cat virtuous-cat added 📦 boba-components An issue that involves the boba-components repository 🛶 Small 🌤 Easy 🎨 Frustration busters Make BobaBoard a pleasure to use 🛠 React Is familiar with the React Framework 🔥🔥P3 🛠 CSS and removed 🚧 To sort Auto-added to all issues; removed after issues have been reviewed and classified labels Sep 19, 2022
@essential-randomness essential-randomness added the 📉 The Big Issues Bankruptcy of 2023 Sometimes what you need is a fresh start label Aug 16, 2023
@essential-randomness essential-randomness removed the 📉 The Big Issues Bankruptcy of 2023 Sometimes what you need is a fresh start label Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 boba-components An issue that involves the boba-components repository 🛠 CSS 🌤 Easy 🎨 Frustration busters Make BobaBoard a pleasure to use 🛠 React Is familiar with the React Framework 🛶 Small
Projects
None yet
Development

No branches or pull requests

2 participants