Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hidden Thread component should allow setting a note and displaying content notices #62

Open
7 tasks
virtuous-cat opened this issue Jun 22, 2022 · 1 comment
Open
7 tasks

Hidden Thread component should allow setting a note and displaying content notices #62

virtuous-cat opened this issue Jun 22, 2022 · 1 comment
Assignees
@siotle
Labels
☁️ Average 📦 boba-components An issue that involves the boba-components repository 🛠 CSS 🐞 Feature Add a new feature or improve an existing one ⛵️ Medium 🛠 React Is familiar with the React Framework ⏩ Ready to implement 💪 Self-contained The task doesn't have broad repercussions on the BobaBoard codebase

Comments

@virtuous-cat
Copy link
Member

virtuous-cat commented Jun 22, 2022 •
edited by essential-randomness
Loading

Prerequisite: Move HiddenThread component from Frontend codebase to Components codebase BobaBoard/boba-frontend#68

  • Add menuOptions, onSubmitHiddenThreadNote, onShowCns, isRevealed, onReveal, and editable props
  • Show hidden thread note in body of hidden thread placeholder. This can be done with Editor as in the <TextSection> component.
  • Add DropdownListMenu with options from props.menuOptions
  • When note is editable, HiddenThread should have buttons to Save or Cancel
  • Add show cn's button
  • Add reveal button
  • Add appropriate text and buttons when isRevealed = true
@virtuous-cat virtuous-cat mentioned this issue Jun 22, 2022
Open
3 tasks
@essential-randomness essential-randomness added the 🚧 To sort Auto-added to all issues; removed after issues have been reviewed and classified label Sep 16, 2022
@virtuous-cat virtuous-cat added 📦 boba-components An issue that involves the boba-components repository 🛠 React Is familiar with the React Framework ☁️ Average 🔥🔥P3 ⛵️ Medium 🛠 CSS and removed 🚧 To sort Auto-added to all issues; removed after issues have been reviewed and classified labels Sep 19, 2022
@essential-randomness
Copy link
Collaborator

Current design:
image

@essential-randomness essential-randomness added the 📉 The Big Issues Bankruptcy of 2023 Sometimes what you need is a fresh start label Aug 16, 2023
@essential-randomness essential-randomness added 💪 Self-contained The task doesn't have broad repercussions on the BobaBoard codebase ⏩ Ready to implement 🐞 Feature Add a new feature or improve an existing one and removed 📉 The Big Issues Bankruptcy of 2023 Sometimes what you need is a fresh start labels Aug 30, 2023
@essential-randomness essential-randomness changed the title Update hidden thread placeholder UI Hidden Thread component should allow setting a note and displaying content notices Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@siotle siotle

Labels
☁️ Average 📦 boba-components An issue that involves the boba-components repository 🛠 CSS 🐞 Feature Add a new feature or improve an existing one ⛵️ Medium 🛠 React Is familiar with the React Framework ⏩ Ready to implement 💪 Self-contained The task doesn't have broad repercussions on the BobaBoard codebase
Projects
"It's a marathon not a sprint" sprint (🛫Jun 5 — 🛬 July 17)
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@siotle @essential-randomness @virtuous-cat