Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize variable names in server code #95

Open
1 task
essential-randomness opened this issue Sep 26, 2022 · 1 comment
Open
1 task

Standardize variable names in server code #95

essential-randomness opened this issue Sep 26, 2022 · 1 comment
Assignees
Labels
☁️ Average 📦 boba-backend An issue that involves the boba-backend repository 🪲 Dev experience An issue that's not visible to users, but it's definitely visible to developers. 🌤 Easy ⛵️ Medium ⏩ Ready to implement 💪 Volunteer-friendly Can easily be broken down in a way in which a volunteer should have a easy way taking care of it

Comments

@essential-randomness
Copy link
Collaborator

essential-randomness commented Sep 26, 2022

This is a catch-all bug for standardizing variable names in the server (feel free to propose more changes, and create an appropriate bug for each change as you decide to work on it/feel like doing some filing work):

  • Make all string IDs specifically named thingStringId.
@essential-randomness essential-randomness added ⏩ Ready to implement ⛵️ Medium 📦 boba-backend An issue that involves the boba-backend repository 🪲 Dev experience An issue that's not visible to users, but it's definitely visible to developers. 💪 Volunteer-friendly Can easily be broken down in a way in which a volunteer should have a easy way taking care of it ☁️ Average 🌤 Easy labels Sep 26, 2022
@Reptapog Reptapog self-assigned this Sep 30, 2022
@Reptapog
Copy link
Collaborator

Reptapog commented Oct 26, 2022

  • Create constants for test db insert string IDs
  • Swap over all thingStringIds and thing_string_ids to thingExternalId and thing_external_id
  • Remove all references to UUID in variable and method names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☁️ Average 📦 boba-backend An issue that involves the boba-backend repository 🪲 Dev experience An issue that's not visible to users, but it's definitely visible to developers. 🌤 Easy ⛵️ Medium ⏩ Ready to implement 💪 Volunteer-friendly Can easily be broken down in a way in which a volunteer should have a easy way taking care of it
Development

No branches or pull requests

2 participants