Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Support cyclical dependencies in Wiring spec and generated Golang code #9

Open
vaastav opened this issue Sep 15, 2023 · 0 comments

Comments

@vaastav
Copy link
Contributor

vaastav commented Sep 15, 2023

In GitLab by @JonathanMace on Sep 16, 2023, 24:47

The current Wiring spec implementation will recurse infinitely if there are cyclical node dependencies. Similarly, the golang DI graph would recurse infinitely if there were cyclical dependencies.

This is not a fundamental limitation. However, to support cyclical node dependencies might entail tweaking the way IR nodes are constructed, to have constructor injection as well as setter-based injection.

This will be a major change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants